Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes dotnet/templating#3804 implements search subcommand #4054

Merged
merged 4 commits into from
Oct 26, 2021
Merged

fixes dotnet/templating#3804 implements search subcommand #4054

merged 4 commits into from
Oct 26, 2021

Conversation

vlada-shubina
Copy link
Member

Problem

fixes #3804

Solution

implements search subcommand

Checks:

  • Added unit tests
  • Added #nullable enable to all the modified files ?

@vlada-shubina vlada-shubina requested a review from a team as a code owner October 25, 2021 08:34
bekir-ozturk
bekir-ozturk suggested changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@bekir-ozturk bekir-ozturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make your peace with CI. He can be mean sometimes, but he is a nice guy.

src/Microsoft.TemplateEngine.Cli/Commands/BaseCommand.cs Outdated Show resolved Hide resolved
src/Microsoft.TemplateEngine.Cli/Commands/BaseCommand.cs Show resolved Hide resolved
src/Microsoft.TemplateEngine.Cli/Commands/FilterOptionDefinition.cs Outdated Show resolved Hide resolved
src/Microsoft.TemplateEngine.Cli/Commands/FilterOptionDefinition.cs Outdated Show resolved Hide resolved
src/Microsoft.TemplateEngine.Cli/Commands/FilterOptionDefinition.cs Show resolved Hide resolved
src/Microsoft.TemplateEngine.Cli/Commands/SearchCommand.cs Outdated Show resolved Hide resolved
src/Microsoft.TemplateEngine.Cli/Commands/SearchCommand.cs Show resolved Hide resolved
src/Microsoft.TemplateEngine.Cli/Commands/SearchCommand.cs Outdated Show resolved Hide resolved
src/Microsoft.TemplateEngine.Cli/Commands/SharedOptionsFactory.cs Outdated Show resolved Hide resolved
test/Microsoft.TemplateEngine.Cli.UnitTests/ParserTests/SearchTests.cs Show resolved Hide resolved
DavidKarlas
DavidKarlas approved these changes Oct 25, 2021
View reviewed changes
src/Microsoft.TemplateEngine.Cli/CommandParsing/CommandParserSupport.cs Show resolved Hide resolved
src/Microsoft.TemplateEngine.Cli/Commands/BaseCommand.cs Show resolved Hide resolved
src/Microsoft.TemplateEngine.Cli/Commands/FilterOptionDefinition.cs Outdated Show resolved Hide resolved
src/Microsoft.TemplateEngine.Cli/Commands/FilterOptionDefinition.cs Outdated Show resolved Hide resolved
src/Microsoft.TemplateEngine.Cli/Commands/NewCommand.cs Show resolved Hide resolved
src/Microsoft.TemplateEngine.Cli/Commands/SearchCommand.cs Show resolved Hide resolved
src/Microsoft.TemplateEngine.Cli/Commands/SearchCommand.cs Show resolved Hide resolved
src/Microsoft.TemplateEngine.Cli/LocalizableStrings.resx Show resolved Hide resolved
src/Microsoft.TemplateEngine.Cli/TemplateSearch/CliSearchFiltersFactory.cs Show resolved Hide resolved
@vlada-shubina vlada-shubina merged commit c891909 into dotnet:feature/system-command-line Oct 26, 2021
@vlada-shubina vlada-shubina deleted the search branch October 26, 2021 10:08
vlada-shubina added a commit to vlada-shubina/templating that referenced this pull request Nov 22, 2021
@vlada-shubina
fixes dotnet#3804 implements search subcommand (dotnet#4054)
bc5e968 
* fixes dotnet#3804 implements search subcommand
* Args.Language implementation
* removed FilterDefinition.Name
vlada-shubina added a commit that referenced this pull request Nov 26, 2021
@vlada-shubina
fixes #3804 implements search subcommand (#4054)
5fa2e10 
* fixes #3804 implements search subcommand
* Args.Language implementation
* removed FilterDefinition.Name
vlada-shubina added a commit that referenced this pull request Dec 21, 2021
@vlada-shubina
fixes #3804 implements search subcommand (#4054)
8334eac 
* fixes #3804 implements search subcommand
* Args.Language implementation
* removed FilterDefinition.Name
vlada-shubina added a commit to vlada-shubina/templating that referenced this pull request Dec 23, 2021
@vlada-shubina
fixes dotnet#3804 implements search subcommand (dotnet#4054)
9a9b8c1 
* fixes dotnet#3804 implements search subcommand
* Args.Language implementation
* removed FilterDefinition.Name
vlada-shubina added a commit that referenced this pull request Jan 11, 2022
@vlada-shubina
fixes #3804 implements search subcommand (#4054)
de6a53c 
* fixes #3804 implements search subcommand
* Args.Language implementation
* removed FilterDefinition.Name
vlada-shubina added a commit that referenced this pull request Jan 27, 2022
@vlada-shubina
fixes #3804 implements search subcommand (#4054)
f2245ca 
* fixes #3804 implements search subcommand
* Args.Language implementation
* removed FilterDefinition.Name
vlada-shubina added a commit that referenced this pull request Jan 28, 2022
@vlada-shubina
fixes #3804 implements search subcommand (#4054)
a6bfe8b 
* fixes #3804 implements search subcommand
* Args.Language implementation
* removed FilterDefinition.Name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bekir-ozturk bekir-ozturk bekir-ozturk approved these changes

@DavidKarlas DavidKarlas DavidKarlas approved these changes

Assignees

@vlada-shubina vlada-shubina

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vlada-shubina @DavidKarlas @bekir-ozturk